Z80: "(ix+imm8)" and similar process the constant as `int8_t` (signed 8bit value), i.e. the valid range is (ix-128) to (ix+127).Сообщение от zebest
(ix+128) is invalid instruction.
I guess the IDA does think the constant is `uint8_t` and disassembles like that -> needs fix on the IDA side.
`ld (ix-$ffffff80), a` ... well... I can imagine how this happens (-128 in `int32_t` is encoded as $ff'ff'ff'80), but I really fail to see why assembler should support this, IMO it's disassembler bug too.
The Unreal displays it correctly (in Zilog syntax), and sjasmplus does understand that too.
I.e. "vsjo normalno" as far as I am concerned, I don't see anything ill about this.
I will take a look, sounds good to me, and EMPTYTRD has currently only single argument, so I could extend it without big syntax change. But... see the following point...
I'm pretty sure I have seen some docs where those extensions were specified as valid ones (i.e. others are invalid).
But... the main issue is, that I'm totally unfamiliar with TRD/hobeta, and pretty much all disk systems for ZX (I have been using back in 199x era only TAP files and Didaktik D40 (D80), and I have seen Busy's MB-02 with BDOS). I have never seen TRD/beta/esxdos/... machines before I returned a bit to ZX world due to Next. And the Next itself has NextZXOS based on +3DOS ("+3e") with esxdos compatibility layer and I think all of this is somewhat divMMC inspired/partially compatible? I don't understand this either.
All of these systems are considerably complex (not a 10min read to become expert on them), plus all of them seem to be closed source, and technically not very impressive (compared to MB-02), so I'm learning about them only very slowly and reluctantly, mostly trying to avoid them as much as possible. And it doesn't help the best docs seems to be often in Russian language, slowing my progress further.
So, don't expect miracles from me - if you want TRD/hobeta support improved in sjasmplus, better provide really very detailed and precise info (like the info about disk name), ideally with some links to official system documentation, so I can double-check everything... or even better, prepare pull request with code changes and tests.
I'm always afraid to touch this part of sjasmplus, as I don't know how to test final result (like using the TRD image on real machine or emulator) and the code is not even well covered with automated tests.
So, if you give me simple and precise info, how to fix/improve something, or even write the code, I will try to help you. But outside of that these disk systems are not interesting for me.
Ответить с цитированием